-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resolution for y18n #2445
Merged
Merged
Add resolution for y18n #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethkfman
approved these changes
Mar 29, 2021
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
Gudahtt
added a commit
that referenced
this pull request
Mar 1, 2024
This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3.
Gudahtt
added a commit
that referenced
this pull request
Mar 4, 2024
This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3.
Gudahtt
added a commit
that referenced
this pull request
Mar 4, 2024
This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3.
Gudahtt
added a commit
that referenced
this pull request
Mar 4, 2024
This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3.
Gudahtt
added a commit
that referenced
this pull request
Mar 4, 2024
This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3.
Gudahtt
added a commit
that referenced
this pull request
Mar 4, 2024
This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3.
Gudahtt
added a commit
that referenced
this pull request
Mar 4, 2024
This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3.
Gudahtt
added a commit
that referenced
this pull request
Mar 4, 2024
## **Description** This resolution was added in #2445 to update the package to resolve a security advisory. The resolution wasn't really needed for the update; effectively the resolution has only resulted in the package being downgraded to v3. ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the yarn audit scrip caught a vulnerability in
y18n
. this fixes that.