Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix 507 #5337

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Bug Fix 507 #5337

merged 1 commit into from
Dec 2, 2022

Conversation

blackdevelopa
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Fixes https://github.com/MetaMask/mobile-planning/issues/507

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?

Screenshots/Recordings
http://recordit.co/C1HW6fB1AR

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner December 2, 2022 15:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa changed the title fix 507 Bug Fix 507 Dec 2, 2022
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 2, 2022
@sethkfman sethkfman added release-5.12.0 Issue or pull request that will be included in release 5.12.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 2, 2022
@cortisiko cortisiko added the QA in Progress QA has started on the feature. label Dec 2, 2022
cortisiko
cortisiko approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Dec 2, 2022
@cortisiko cortisiko merged commit 20c21d3 into release/5.12.0 Dec 2, 2022
@cortisiko cortisiko deleted the fix/507_updated branch December 2, 2022 17:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-5.12.0 Issue or pull request that will be included in release 5.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blackdevelopa @cortisiko @gantunesr @sethkfman