Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix 507 #5337

Merged
merged 1 commit into from
Dec 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/components/Views/SendFlow/Confirm/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -743,6 +743,7 @@ class Confirm extends PureComponent {
AnalyticsV2.ANALYTICS_EVENTS.SEND_TRANSACTION_COMPLETED,
this.getAnalyticsParams(),
);
stopGasPolling();
blackdevelopa marked this conversation as resolved.
Show resolved Hide resolved
resetTransaction();
navigation && navigation.dangerouslyGetParent()?.pop();
});
Expand Down
2 changes: 0 additions & 2 deletions app/core/GasPolling/GasPolling.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,6 @@ export const getLegacyTransactionData = ({
gas,
onlyGas,
}: LegacyProps) => {
blackdevelopa marked this conversation as resolved.
Show resolved Hide resolved
// hack: selectedAsset becomes an empty object when legacy transaction is submitted and it breaks the app. See Line 1241 in util/transactions.js
transactionState.selectedAsset.isETH = true;
const parsedTransationData = parseTransactionLegacy(
{
contractExchangeRates,
Expand Down