[IMPROVEMENT] Refactor Analytics Events #5454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantunesr
added
the
needs-dev-review
owencraston
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
I didn't run the app but all the events seem to match.
Unrelated but I created this util for generateDeviceAnalyticsMetaData. Perhaps this is something we want to move in future changes or even make it a part of all the events? Just thought i'd mention it here to create the paper trail. Nice work 👍
jpcloureiro
suggested changes
Jan 5, 2023
…to refactor/analytics-events
jpcloureiro
approved these changes
Jan 5, 2023
gantunesr
added
No QA Needed
|
Nice @owencraston, I'll keep it in mind for the next analytics PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
As part of the Segment integration, it's required to do a series of refactors on the app analytics system. The PR #5139 is the main migration development, but getting the events refactor merged will help to reduce the number of code conflicts.
2. What is the improvement/solution?
Refactor the analytics events and centralize them into a single file
app/core/Analytics/MetaMetrics.events.tsScreenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your changeIssue
Progresses https://github.com/MetaMask/mobile-planning/issues/372
Related to PR #5139
Checklist