Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: Bump devDependencies #108

Merged
merged 10 commits into from
Nov 7, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 6, 2023

Update many of the devDependencies for this package to get latest fixes.

Does not update peerDependencies of @metamask/eslint-config packages (typescript, eslint*, prettier)

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 6, 2023
@legobeat legobeat marked this pull request as ready for review September 6, 2023 08:36
@legobeat legobeat requested a review from a team as a code owner September 6, 2023 08:36
@socket-security
Copy link

socket-security bot commented Sep 6, 2023

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@playwright/test 1.39.0...1.33.0 eval, filesystem, shell, environment +1/-2 9.9 MB aslushnikov
fs-extra 10.1.0...11.1.1 None +0/-0 59.5 kB ryanzim
playwright 1.39.0...1.33.0 None +1/-1 7.14 MB aslushnikov

🚮 Removed packages: @lavamoat/[email protected], @testing-library/[email protected], @testing-library/[email protected], @types/[email protected]

@socket-security
Copy link

socket-security bot commented Sep 6, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], [email protected], @lavamoat/[email protected], @playwright/[email protected], [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

legobeat commented Sep 6, 2023

@SocketSecurity ignore [email protected]

binscript confusion: playwright and playwright-core provide the same bin. Must be intentional on their side 🤷

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just one question.

"http-server": "^14.1.1",
"minify-stream": "^2.1.0",
"playwright": "^1.30.0",
"playwright": "~1.33.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ~?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.34.0 and newer exit with:

    Please install @playwright/test package before running "yarn playwright test"
      yarn remove playwright
      yarn add -D @playwright/test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How rude!

@legobeat legobeat force-pushed the devDeps-bumps branch 2 times, most recently from 049aabc to 7e5ca75 Compare October 13, 2023 02:10
@legobeat legobeat requested review from mcmire and a team October 31, 2023 00:53
@legobeat legobeat requested a review from brad-decker November 7, 2023 00:46
@legobeat
Copy link
Contributor Author

legobeat commented Nov 7, 2023

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore @lavamoat/[email protected]

new author ok

@legobeat
Copy link
Contributor Author

legobeat commented Nov 7, 2023

@SocketSecurity ignore @playwright/[email protected]
@SocketSecurity ignore [email protected]

bin script confusion, shell access

@legobeat legobeat merged commit 0dc3ec1 into MetaMask:main Nov 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants