[WIP] remove underscore #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for userIsInRole helper: Check to handle when `userRoles` is null.
The first two JavaScript code samples lacked syntax highlighting.
…/readme-update Updated README: syntax highlighting
Fix mistake in removeUsersFromRoles comment
…eny-1.0.9 updated allow-deny package to v1.0.9
remove idea
|
That same test fails on the master branch too, so I don't think this PR caused it. |
|
Closing in favor of #288. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as underscore is slowly removed from meteor core, i guess it should be in userland as well to leverage the benefits.
not sure when i find time to continue this (there's still one test failing and it was not immediately clear to me why)