Remove underscore, add ecmascript package #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.js # roles/client/uiHelpers.js # roles/roles_common.js
|
LGTM |
|
I've merged #279 as well, so this has everything now. |
CaptainN
changed the title
CaptainN
commented
Oct 8, 2019
| @@ -306,9 +315,9 @@ _.extend(Roles, { | |||
| */ | |||
There was a problem hiding this comment.
Please take a look at this function (_addRoleToParent) and make sure there is no regression happening. Tests all pass, but this is different enough from the underscore version that it's worth getting a few more eye balls on it.
This was referenced Oct 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes underscore from the client bundle, and adds ecmascript. All tests are passing.