Changes after removing underscore #292
Conversation
|
I wasn't really aware of the plans when I did my PR. I just did it against the v2 branch since that is the current version. Also, I was not aware of your PR until after I went ahead with my PR. The only reason I favored my changes was that I worked on it some months more recently, and wasn't sure how stale your PR would be. I don't feel precious about any of it - you can even close my PR and restore yours if you prefer. I just wanted to help remove underscore. :-) |
|
@CaptainN thanks for your feedback. When reading through the changes I did in comparison to yours, do you personally see something which obvious is to fail? Otherwise I'd merge this PR in. @StorytellerCZ I would also like to hear your feedback if you have time to take a look at it. If you approve, I'll go ahead and merge all the other PRs I have in store in order to finally release a v3. |
@CaptainN this is a list of changes which I saw while comparing your PR #288 to the one I created quite a while ago, which you also included.
Since all of my changes on v3 - and also some I would like to include in v2 - are based on this PR, I'd like to explain your changes.