-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixpkgs-review finding more packages than it should #446
Comments
Was your evaluation done locally or based on github evaluation? |
I always run with BTW after deleting all nixpkgs worktrees in .cache it seems that the issue went away. Not sure about what caused but it looks like it's not happening anymore. |
It seems like some issue around worktree destruction and maybe some eventual consistency issue in ZFS but I can't confirm. When the issue happens, I have to delete the non used worktrees and run a worktree prune there. Still, there are some PRs in the queue. ts when it start the task it runs nixpkgs-review in a systemd unit using |
It seems to be happening after I cancel a run then systemd force stop stuff and cleanup doesn't happen properly. I changed the enqueue script |
It's still happening even with an ext4 partition and sync after It seems there is some issue around running a review right after another |
NixOS/nixpkgs#369758 (comment)
|
Running the nixpkgs-review from nixpkgs master (nix run nixpkgs#nixpkgs-review)
NixOS/nixpkgs#369313
https://github.com/lucasew/nixcfg/actions/runs/12561592809
Both cases should only show one package as it's a leaf package.
The text was updated successfully, but these errors were encountered: