Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashlink: fix build with gcc-14 #369800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paparodeo
Copy link
Contributor

fixes: #368216

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Jan 1, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369800


x86_64-linux

❌ 1 package failed to build:
  • worldofgoo
✅ 2 packages built:
  • hashlink
  • megasync

@paparodeo
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369800

x86_64-linux

❌ 1 package failed to build:
✅ 2 packages built:

https://github.com/NixOS/nixpkgs/actions/runs/12564450512/attempts/1#summary-35027677217 only lists 1 rebuild and hashlink. this doesn't seem correct.

@lucasew
Copy link
Contributor

lucasew commented Jan 1, 2025

This may be Mic92/nixpkgs-review#446

@paparodeo
Copy link
Contributor Author

cc maintainers: @iblech @locallycompact @l0go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: hashlink
2 participants