xzoom: fix gcc-14 #369803
Merged
xzoom: fix gcc-14 #369803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include `unistd.h` to fix implicit function declaration errors
github-actions
bot
added
10.rebuild-darwin: 0
|
@lucasew thanks for running nixpkgs review but this doesn't appear to match this PR. off all these packages, the only one that gets rebuild when xzoom changes is xzoom.-- the GHA rebuild count only lists |
|
Right now I don't have much idea about the cause. It happens sometimes. |
|
cc maintainer: @7c6f434c |
gepbird
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Thanks! I was about to open the same PR
Tested the binary on x86_64-linux, LGTM
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 369803
x86_64-linux
✅ 1 package built:
- xzoom
(no issues with nixpkgs-review, probably because I'm running it on a VM I rarely update)
gepbird
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include
unistd.hto fix implicit function declaration errorsfixes: #369034
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.