GD-486: Fix image size errors at startup

[MikeSchulze]

Why

On macOS there are errors on startup.

Godot Engine v4.2.1.stable.official (c) 2007-present Juan Linietsky, Ariel Manzur & Godot Contributors.
  core/variant/variant_utility.cpp:1091 - invalid height:16 vs 32
  Invalid image: null
  core/variant/variant_utility.cpp:1091 - invalid height:16 vs 32
  Invalid image: null
  core/variant/variant_utility.cpp:1091 - invalid height:16 vs 32
  Invalid image: null
  core/variant/variant_utility.cpp:1091 - invalid height:16 vs 32
  Invalid image: null
  core/variant/variant_utility.cpp:1091 - invalid height:16 vs 32
  Invalid image: null
  core/variant/variant_utility.cpp:1091 - invalid height:16 vs 32
  Invalid image: null
Loading GdUnit4 Plugin success

What

• disable the image size check when merge icons because it has different size on macOS 16vs32 pixels

[didierGuieu]

Not sure, it's only linked to macos. it's also probably linked to the hiDPI monitor.
Pehraps you need to check with EditorInterface.get_editor_scale()
https://docs.godotengine.org/en/stable/classes/class_editorinterface.html#class-editorinterface-method-get-editor-scale
In my case, the factor is 2.0 and it's exactly the scale factor encountered in the errors.

[MikeSchulze]

Not sure, it's only linked to macos. it's also probably linked to the hiDPI monitor. Pehraps you need to check with EditorInterface.get_editor_scale() https://docs.godotengine.org/en/stable/classes/class_editorinterface.html#class-editorinterface-method-get-editor-scale In my case, the factor is 2.0 and it's exactly the scale factor encountered in the errors.

Thanks for the hint, I will check this.

[MikeSchulze]

Thanks for the feedback, yes you are right.
I checked, and the image is scaled, I use scale 150% also on Windows.

  core/variant/variant_utility.cpp:1091 - invalid height:16 vs 24
  Invalid image: null
check icon size 16 24