Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] mark don't work right #553

Closed
4-1-1 opened this issue Jun 8, 2022 · 6 comments
Closed

[Bug] mark don't work right #553

4-1-1 opened this issue Jun 8, 2022 · 6 comments
Assignees
Labels
bug Something isn't working planned This issue is being planned in iteration

Comments

@4-1-1
Copy link

4-1-1 commented Jun 8, 2022

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

import React from 'react';
import { render } from 'react-dom';

import { Milkdown } from './component/milkdown';

const markdown = `
abc**'de**
`;

const App: React.FC = () => {
    return <Milkdown value={markdown} />;
};

render(<App />, document.getElementById('app'));

Expected behavior
It should be bold 'de

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS] macos
  • Browser [e.g. chrome, safari] chrome
  • Version [e.g. 22] 101

milkdown version 6.1.3

Additional context
Add any other context about the problem here.

@4-1-1 4-1-1 added the bug Something isn't working label Jun 8, 2022
@Saul-Mirone
Copy link
Member

That's how markdown work
https://spec.commonmark.org/0.30/#left-flanking-delimiter-run

At least you should try the syntax on github's comment box to confirm it's a bug.

@Saul-Mirone Saul-Mirone closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2022
@4-1-1
Copy link
Author

4-1-1 commented Jun 9, 2022

ok ,But some editor works with it。 And the real problem is to bold "'xxx'" with the tooltip menu, and save to preview agian , the bold style gone

@Saul-Mirone Saul-Mirone reopened this Jun 9, 2022
@Saul-Mirone
Copy link
Member

That's a bug I think.

@Saul-Mirone
Copy link
Member

Saul-Mirone commented Jun 9, 2022

Seems it's about example 358.

Screen Shot 2022-06-09 at 12 27 30

@4-1-1
Copy link
Author

4-1-1 commented Jun 9, 2022

Do you have any plan, to support it ? or update the input rules and mark command?

@Saul-Mirone
Copy link
Member

I'll figure out how to do it when I have time.

@Saul-Mirone Saul-Mirone added the planned This issue is being planned in iteration label Jun 11, 2022
@Saul-Mirone Saul-Mirone added this to the [email protected] milestone Aug 14, 2022
Saul-Mirone added a commit that referenced this issue Aug 22, 2022
@Saul-Mirone Saul-Mirone mentioned this issue Aug 29, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned This issue is being planned in iteration
Projects
None yet
Development

No branches or pull requests

2 participants