-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issues with tables that contain non-comparable columns #923
Conversation
I made these changes in a style to mimic existing code. Feel welcome to tweak it, reformat it, etc. in any way you would like |
I'm not sure what to do with the failed MySql & MariaDB Tests. This PR doesn't touch any of that functionality. If I need to do something to fix these tests, please let me know. |
Hey @SvdSinner I've reviewed your PR, and I think you've found a pretty interesting solution. I've reviewed the SQL generated by the If there is no filter, there is no benefits to add a I'm currently working on refactoring tests and some providers routine, but once it's done, I will work on your PR, to fix everything. Thanks for this great solution to improve the support of old |
I realized there were some bugs in the ChangeTracking project that this caused. There is now a new commit that fixes the 3 typos that caused the bugs. |
Hey @SvdSinner Sorry to come back to you so late. I've made some adjustments in the Once it's done, I will make the rights adjustments to integrate the corresponding's tests and be sure it's working fine with all the other providers. Thanks a ton for your contribution! |
…into FixNonComparableColumns # Conflicts: # Projects/Dotmim.Sync.SqlServer/Builders/SqlBuilderProcedure.cs
Thanks ! |
I'm sorry @SvdSinner, I had to revert back your PR (see #936 ) as all tests are failing. |
Fixes issues with tables that contain non-comparable columns (XML, TXT, NTEXT)