Fix non comparable columns #938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this pull request only grabbed the fix, rather than grabbing all the code that was in the original pull request. ( #923 ) You may have to apply them both. I don't have a lot of experience with re-applying a PR after reverting it. |
|
Please submit a PR that I can review with all the code and tests passed :) |
|
Sounds good. I will close this PR and am working on the new one. One question: Is there an artifact that I need to create and submit for "all tests passed" or just make sure they all pass now that I figured out how to get them to run? |
|
Just make them pass :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous bug has been fixed. Re-submitting.