Fix a few bugs in revalidate (mini)
#16401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two similar issues originating from confusion between previous variable names `t` and `t'`, affecting cases: - `Account no longer has permission to send` - `Current account nonce precedes first nonce in queue`
Fix the issue #16397 by ensuring removal from `applicable_by_fee` is done only for the previous head of queue.
georgeee
force-pushed
the
georgeee/fix-16397-mini
branch
from
f4a890a to
1b95a6e
Compare
deepthiskumar
approved these changes
Dec 9, 2024
| @@ -739,14 +739,14 @@ let revalidate : | |||
| then ( | |||
| [%log debug] | |||
| "Account no longer has permission to send; dropping queue" ; | |||
| let dropped, t'' = remove_with_dependents_exn' t_initial first_cmd in | |||
| (t'', Sequence.append dropped_acc dropped) ) | |||
| let dropped, t_updated = remove_with_dependents_exn' t first_cmd in | |||
|
!ci-build-me |
|
!ci-build-me |
georgeee
force-pushed
the
georgeee/fix-16397-mini
branch
from
17befc9 to
1b95a6e
Compare
8 tasks
|
!approved-for-mainnet |
sebastiencs
added a commit
to openmina/openmina
that referenced
this pull request
Jan 15, 2025
Apply changes from MinaProtocol/mina#16401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tandt'(Account no longer has permission to sendandCurrent account nonce precedes first nonce in queue)applicable_by_feeisdone only for the previous head of queue.
Explain how you tested your changes:
Checklist