Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compatible] Fix a few bugs in revalidate (mini) #16465

Closed
wants to merge 2 commits into from

Conversation

georgeee
Copy link
Member

Twin of #16401 against compatible

  1. Fix two similar issues originating from confusion between previous variable names t and t' (Account no longer has permission to send and Current account nonce precedes first nonce in queue)
  2. Fix the issue multiple nodes crashed #16397 by ensuring removal from applicable_by_fee is
    done only for the previous head of queue.

Explain how you tested your changes:

Checklist

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@georgeee georgeee requested a review from a team as a code owner January 14, 2025 16:04
Copy link
Contributor

mergify bot commented Jan 14, 2025

⚠️ The sha of the head commit of this PR conflicts with #16401. Mergify cannot evaluate rules on this PR. ⚠️

@mrmr1993
Copy link
Member

This PR now represents an empty diff. Closing.

@mrmr1993 mrmr1993 closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants