Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compile-time genesis proof creation optional #8497

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Apr 1, 2021

This PR makes compile-time proof generation optional, with tweaks to remove the dependency everywhere except Genesis_ledger_helper.

This is configurable by a flag in config.mlh. At the moment, it's disabled everywhere, but this gives us the option of generating a proof for mainnet binaries at compile-time so that we don't have to bundle a proof file with the executable.

Tested by running CI, where everything succeeds.

Checklist:

  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them:

@mrmr1993 mrmr1993 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Apr 1, 2021
@mrmr1993 mrmr1993 marked this pull request as ready for review April 1, 2021 20:09
@mrmr1993 mrmr1993 requested review from a team as code owners April 1, 2021 20:09
@bkase
Copy link
Member

bkase commented Apr 7, 2021

!approved-for-mainnet

@mrmr1993 mrmr1993 merged commit 739a41b into compatible Apr 7, 2021
@mrmr1993 mrmr1993 deleted the feature/optional-compiled-genesis-proof branch April 7, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants