-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using hard-coded compile-time verification keys #8584
Conversation
Reviewer guide:
|
!approved-for-mainnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this fatal error when constraint constants don't match?
[%log fatal] |
I think we should do this as a follow-up PR, I've tested the signatures interaction for this series, but I'd like to test changing the constraint constants themselves before we go all in. |
This PR builds upon #8497. This ensures that we don't depend on verification keys from the
Precomputed_values
library, which will not necessarily be the correct ones if we switch between signature schemes.Checklist: