-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lk86/locking config and read committed #9885
Merged
lk86
merged 23 commits into
rosetta-1.2.1-safe
from
lk86/locking-config-and-read-committed
Dec 15, 2021
Merged
Lk86/locking config and read committed #9885
lk86
merged 23 commits into
rosetta-1.2.1-safe
from
lk86/locking-config-and-read-committed
Dec 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation and update postgres.conf
…onfig is in use and to avoid deleting the postgres cluster each run
lk86
added
the
ci-build-me
Add this label to trigger a circle+buildkite build for this branch
label
Nov 30, 2021
…re resilient to the empty starting state
…coded configuration file as the --createclusterconf
… to only use our new values
bkase
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rewrite the pr description?
…lation and make postgresql.conf easier to maintain
…for an even larger shared memory pool
…ransaction but not pred locks
…e hopes of removing auth issues
…cking-config-and-read-committed
… environment-based configurations
…cking-config-and-read-committed
bkase
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
…d rosetta path to avoid python dependencies
…to remove deprecated flag
…/locking-config-and-read-committed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to refactor the database setup steps to be easier to edit and maintain over time, as well as provides new default values for everything in
src/app/rosetta/postgres.conf
with up to 5 million table locks. The rosetta.conf files were also updated as one of the former fields has been deprecated. This PR also includes the changes from #9911 so that I could test them together and make sure results were equivalent to ubuntu 18.04 and results were in fact similar. My testing did not complete all the way through syncing + 0.95% reconciled after the tip but it did sync all the way with 0 reconciliation failures before an eventual crash.