Lk86/support ubuntu20.04 in Rosetta staged dockerfile #9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d rosetta path to avoid python dependencies
lk86
changed the title
lk86
added
the
ci-build-me
psteckler
approved these changes
Dec 14, 2021
bkase
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes prior work to refactor the toolchain stage out of the normal rosetta pipeline, which avoids porting the python dependencies for the integration tests and various other tools for ubuntu 20. Debian-only for those should suffice as our tests and tools in debian can still be used to deploy + test ubuntu images.
The version of rocksdb we depend on (via ocaml-rocksdb) does not build in the latest g++ without disabling some deprecation warnings, so we had to silence those, and the final ubuntu 20 dependencies are different but largely the build process still works well in ubuntu 20 and the node seems to perform comparably in rosetta testing.
We should consider upgrading to an ocaml-rocksdb version that supports rocksdb 6 but that's a problem for another ticket.