Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS-specific environment variables #600

Merged
merged 9 commits into from
May 2, 2017
Merged

Support AWS-specific environment variables #600

merged 9 commits into from
May 2, 2017

Conversation

longzhi
Copy link
Contributor

@longzhi longzhi commented Jan 16, 2017

Description

Support AWS-specific environment variables.

GitHub Issues

#501

@coveralls
Copy link

coveralls commented Jan 16, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-25.0%) to 57.73% when pulling d55cb61 on longzhi:master into 8c2b1b4 on Miserlou:master.

@longzhi longzhi mentioned this pull request Jan 16, 2017
Closed
@coveralls
Copy link

coveralls commented Jan 16, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 82.708% when pulling a5889b4 on longzhi:master into 8c2b1b4 on Miserlou:master.

@coveralls
Copy link

coveralls commented Jan 16, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 82.739% when pulling b1b7813 on longzhi:master into 8c2b1b4 on Miserlou:master.

@Miserlou
Copy link
Owner

Related: #549

@Miserlou
Copy link
Owner

For both of those, I only want to accept the PR when KMS support is enabled and documented.

@kvey
Copy link

kvey commented Mar 28, 2017

This appears to be in master

@Miserlou
Copy link
Owner

@kvey - the environment variables in Zappa were built before AWS supported their own environment variables, but they function the same. The only reason to swap would be to support KMS, but this PR doesn't support that.

@coveralls
Copy link

coveralls commented Apr 25, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-23.07%) to 52.72% when pulling e4cf061 on longzhi:master into a23eb6a on Miserlou:master.

@coveralls
Copy link

coveralls commented Apr 25, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-23.07%) to 52.72% when pulling 37e971b on longzhi:master into a23eb6a on Miserlou:master.

@coveralls
Copy link

coveralls commented Apr 25, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 75.883% when pulling c44b548 on longzhi:master into a23eb6a on Miserlou:master.

@richiverse
Copy link
Contributor

Nice! Actually needed something like this lately

@Miserlou Miserlou merged commit 8fd0142 into Miserlou:master May 2, 2017
@wagmiwiz wagmiwiz mentioned this pull request Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@longzhi @coveralls @Miserlou @kvey @richiverse