Simplify CLI #17
Open
Simplify CLI #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
suggested changes
May 23, 2024
|
|
||
| ## Install | ||
|
|
||
| Install dependencies. `libdw1` is required to run Stone and `wget` to download the installation script. |
There was a problem hiding this comment.
Why did you remove this line?
| * Run, prove and verify any Cairo program | ||
| * Run programs directly or with the Starknet bootloader for | ||
| compatibility with the Starknet L1 verifier | ||
| * Automatic generation of the prover configuration and parameters. |
There was a problem hiding this comment.
Why did you remove these features from the README? The CLI can do all this.
| @@ -50,7 +50,7 @@ impl FromStr for Bootloader { | |||
| #[command(args_conflicts_with_subcommands = true)] | |||
| #[command(flatten_help = true)] | |||
| pub struct ProveArgs { | |||
| #[clap(long = "with-bootloader", default_value_t = false)] | |||
| #[clap(long = "with-bootloader", default_value_t = true)] | |||
There was a problem hiding this comment.
Geoffrey is implementing this + adding tests. With this change you do not provide a way to disable the bootloader mode. See #18 for the suggested implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.