Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bootloader mode the default #18

Merged
merged 12 commits into from
May 23, 2024
Merged

Make bootloader mode the default #18

merged 12 commits into from
May 23, 2024

Conversation

whichqua
Copy link
Contributor

@whichqua whichqua commented May 23, 2024 •
edited
Loading

This allows both the argument '--with-bootloader' and '--no-bootloader'.
Both cant be used at the same time.

TODO

  • Update docs

@whichqua whichqua requested a review from odesenfans May 23, 2024 10:38
@odesenfans odesenfans mentioned this pull request May 23, 2024
Open
odesenfans
odesenfans suggested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the right path, 2 things to change.

src/cli.rs Outdated Show resolved Hide resolved
tests/test_prove.rs Show resolved Hide resolved
tests/test_prove.rs Show resolved Hide resolved
odesenfans
odesenfans suggested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more doc changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@odesenfans odesenfans merged commit f7bf9d9 into main May 23, 2024
1 check passed
@odesenfans odesenfans deleted the feat/no-bootloader branch May 23, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odesenfans odesenfans odesenfans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whichqua @odesenfans