Details (world preview) screen causes environment/context corruption #2509
Labels
Topic: Architecture
Requests, Issues and Changes related to software architecture, programming patterns, etc.
Type: Bug
Issues reporting and PRs fixing problems
Milestone
The "Details" button (which lists world config options and allows previewing the world) is at present somewhat problematic. It involves module environment / context switches to be able to activate additional modules (to be able to preview a world gen in a module) which isn't quite solid yet. Some problems:
The preview / config step does function in some cases and if you immediately start the game it does function. But it seems attempting to tweak further breaks the game. There are some more notes in #1780
An earlier attempt to streamline this was #2068 which was implemented in still-pending PR #2074 by @msteiger. That led to errors some of which at least seem to match the ones even without the PR. Probably there are things we can fix that'll help both cases.
In the meanwhile this is poor usability and even if we can't get back to work on the full #2074 implementation (module / environment context stuff is pretty deep architecture) maybe we can improve the experience.
Worth noting is that when you use the functionality and start a game, then return to the main menu then the environment setup appears to be solid and usable again. Something in the context switch for entering a full game then leaving correctly achieves something that the Details functionality does not.
The text was updated successfully, but these errors were encountered: