Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details (world preview) screen causes environment/context corruption #2509

Closed
Cervator opened this issue Oct 8, 2016 · 0 comments · Fixed by #2815
Closed

Details (world preview) screen causes environment/context corruption #2509

Cervator opened this issue Oct 8, 2016 · 0 comments · Fixed by #2815
Labels
Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. Type: Bug Issues reporting and PRs fixing problems

Comments

@Cervator
Copy link
Member

Cervator commented Oct 8, 2016

The "Details" button (which lists world config options and allows previewing the world) is at present somewhat problematic. It involves module environment / context switches to be able to activate additional modules (to be able to preview a world gen in a module) which isn't quite solid yet. Some problems:

  • The screen stalls the game for a moment as (I believe) it is scanning/enabling the selected modules to be able to present any configurable toggles (it doesn't actually create a world preview, but at this point it might as well)
  • On closing the screen it takes a moment again as I guess it reloads the standard environment (without extra modules). But something goes awry here - clicking Details again causes an error and while it doesn't crash the game the client becomes unreliable
  • After closing the screen but not re-entering Details the next attempted module/context swap fails, such as exiting away from the create game screen then trying again (modules/world generators fail to list). This seems to break the game client a little worse and you have to process kill the game somehow (different error)
  • Not all world types work - for instance Throughout The Ages processes for a while but then fails with the same error as retrying details

The preview / config step does function in some cases and if you immediately start the game it does function. But it seems attempting to tweak further breaks the game. There are some more notes in #1780

An earlier attempt to streamline this was #2068 which was implemented in still-pending PR #2074 by @msteiger. That led to errors some of which at least seem to match the ones even without the PR. Probably there are things we can fix that'll help both cases.

In the meanwhile this is poor usability and even if we can't get back to work on the full #2074 implementation (module / environment context stuff is pretty deep architecture) maybe we can improve the experience.

Worth noting is that when you use the functionality and start a game, then return to the main menu then the environment setup appears to be solid and usable again. Something in the context switch for entering a full game then leaving correctly achieves something that the Details functionality does not.

@Cervator Cervator added Type: Bug Issues reporting and PRs fixing problems Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. labels Oct 8, 2016
0shine0 added a commit to 0shine0/Terasology that referenced this issue Mar 8, 2017
…game after previewing and re-entering again crashes the game
0shine0 added a commit to 0shine0/Terasology that referenced this issue Mar 12, 2017
…game after previewing and re-entering again crashes the game
@Cervator Cervator added this to the Alpha 7 milestone Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant