Extract ThreadManager and introduce EngineStatus #1797
Conversation
…erasology engine.
Keep Splash Screen open until load complete.
|
Refer to this link for build results (access rights to CI server needed): |
|
Poking potentially interested parties: @msteiger @MarcinSc @prestidigitator @flo @synopia Edit: And @emanuele3d for good measure :-) |
|
It's better then what we had be fore. So I am up for merging it. |
|
|
||
| /** | ||
| * Engine Status provides the current status of the engine - what it is doing, at a higher granularity than just running. This can be used by external and internal observers | ||
| * to report on the state of the engine, such as splash screens/loading screens. |
There was a problem hiding this comment.
Looking here on github there seems to be some newline issue here. Not a problem when browsing the javadoc via browser I imagine but would be nice to fix for people dealing with the source.
There was a problem hiding this comment.
You mean the line length? It is within our coding standard's max line length. Unless we want to change that length.
There was a problem hiding this comment.
Now I understand. Disregard this comment then.
| } | ||
|
|
||
| private void cleanup() { | ||
| logger.info("Shutting down Terasology..."); | ||
| shuttingDown = true; | ||
| changeStatus(StandardGameStatus.SHUTTING_DOWN); |
There was a problem hiding this comment.
It seems to me that this line is perhaps redundant with the identical line at the end of mainLoop().
* Simplified build in engine states. Engine no longer tracks and exposes initialization/shuttingdown/disposal states. * Disposal bundled into shutdown. Engine no longer closable. * run() is now synchronized to prevent multiple entry from different threads *
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): Build Log Uh oh, something went wrong with the build. Need to check on that |
immortius
force-pushed
the
engine-lifecycle-redux
branch
from
12edab5 to
58892c5
Compare
|
Refer to this link for build results (access rights to CI server needed): Build Log Uh oh, something went wrong with the build. Need to check on that |
Extract ThreadManager and introduce EngineStatus
|
I wish we could distinguish between unstable (test failures) and build failure in Jenkins on these PR tests (at least the log snippet gives a clue). The "failure" is from a single unit test seemingly breaking Might fail in the main job too, still running. Probably an easy fix :-) Thanks for all the work and review! |
First step of the engine lifecycle redux.
This step