Remove CoreRegistry usage: Part IV #1804
Conversation
It is done by getting the context from the StateIngame. It is the only context that contains the wanted property providers. Only during StateIngame it was actually getting something from the CoreRegisty.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
The original motivation was to get rid of CoreRegistry usage.
|
Refer to this link for build results (access rights to CI server needed): |
|
@immortius able to give this a spin with some review now that #1797 is merged? @emanuele3d - ping, maybe a bit of interest, there's some rendering and TeraEd in there. |
Remove CoreRegistry usage: Part IV
|
@immortius was way too efficient for me. Perhaps he wanted to save @flo from a barrage of comments from me? =D I just had a look and I only found one thing I would have commented about. But it's a very minor, non functional, code style issue and we don't need to worry about. At some point I'll have to put my hands on the WorldRendererImpl class again and I'll do the change then. |
|
@emanuele3d feel free to still create a comment. It is not the last CoreRegistry removal pull request I am creating. So I am happy that @immortius merged it. |
Reduces CoreRegistry usage.
It does not conflict with #1797