Fix checkstyle violations

[Tropid]

Contains

Fixes all checkstyle error violations.

How to test

Run ./gradlew checkstyleMain or open the project in eclipse with the checkstyle plugin active (should also work with any other IDE).

Critical parts

• I added an implementation for equals() in ChunkImpl because the hashCode() method is overwritten
• I renamed some constants in /engine/src/main/java/org/terasology/rendering/openvrprovider/ControllerListener.java
• I changed a lambda expression to an anonymous class instantiation as the checkstyle tool seems to get confused by variable declarations inside lambdas (in my defense, this was a big lambda function so in my opinion it's not really worse to use an anonymous class) -> /engine/src/main/java/org/terasology/logic/console/commandSystem/ConsoleCommand.java

[GooeyHub]

Can one of the admins please verify this patch?

[Cervator]

This one makes me wonder. Under regular circumstances you would indeed expect two chunks at the same location to equal each other. But are we setting ourselves up for potential bugs here?

Two cases come to mind:

• We have a known issue about duplicate chunks being loaded (Crash in multiplayer - chunk loading / rendering null issue, maybe related to dupe chunk loading [$50] #2590) - could this somehow affect that? If somehow a dupe chunk loads but a system interaction changes only one of them. I don't know if dupe chunks at all persist beyond a timing issue or something causing two load requests to be issued.
• In the future could somebody come up with a way where we could have two valid chunks in the same location? Imagine something related to dimensions somehow, either completely separate worlds (why anybody would compare two such chunks I don't know .. but MC does relate the position of Nether chunks vs Overworld chunks so who knows) or in-place chunks where a weird bizarro world shows two different players different chunks. Or phasing maybe (like bits of world with progression locked to individual players)

Perhaps we should add in hashing some additional stuff from each chunk and compare those as well? I don't know how frequently this method is likely used (or really a parent implementation)

[Tropid]

In case of another dimension, we surely should hash another value and also compare another value. But you are correct this could have unforeseen changes.

The important part of the Object contract here should be:

hashCode() must always return the same code for two objects which are equal according to the equals() implementation.

This is true here. I'll adjust the implementation so that equals calls only super and provide a comment why the super equals() implementation is correct in this case.

[Cervator]

Any chance these names are made to match naming in another place, like the VR provider itself?

@indianajohn - ping! :-)

[Tropid]

In this case, I'd suggest adding the SuppressionWarnings module to the checkstyle.xml and add a @SuppressWarnings annotation to the class.

[Cervator]

@Tropid Hi there and thanks! Looking good, noted two things I'm curious about :-)

@GooeyHub: ok to test

[GooeyHub]

Hooray Jenkins reported success with all tests good!

[GooeyHub]

Hooray Jenkins reported success with all tests good!

[Cervator]

Thanks! Merged and added to credits :-)

[Tropid]

Have you noticed I also fixed the violations in the core project? I missed that at first and don't want to sneak in any unnoticed changes.

[Cervator]

I looked over all the affected files just in case, but am not too worried exactly where they are. It's all in the same repository after all :-)