GSOC 2018: First batch of UI changes for multi-world #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New create game flow, final touches
Cervator
added
Topic: Architecture
|
Hooray Jenkins reported success with all tests good! |
16 tasks
Cervator
added a commit
that referenced
this pull request
Jun 18, 2018
# Conflicts: # engine/src/main/java/org/terasology/rendering/nui/layers/mainMenu/SelectGameScreen.java - minor conflicts vs @ar0ne's select game / game details work # engine/src/main/resources/assets/i18n/menu.lang # engine/src/main/resources/assets/i18n/menu_en.lang
This was referenced Jun 18, 2018
Closed
Closed
|
Tested out some more and resolved conflicts. See 1bbc740 for some of the extra work beyond basic conflict resolution. Merged and have also closed affected issues. Thank you @TheFlash98, @msteiger from past work, @nihal111 from helping out, and so on! :-) |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up PR to merge from its topic branch to develop.
In short this batch overhauls the create game UI workflow, fixing some issues with previewing worlds in the process, but temporarily disabling support for advanced configuring of Heightmap. Going straight to playing a gameplay template that defaults to a heightmap world works fine, just more work is needed to hook up a new-style preview for those.
Another tiny but hugely wonderful change: the game now starts when there's more daylight! 🌞
Disclaimer: While the UI suggests multiple worlds can currently be added only the selected world will be available for the player with this PR. I might add a quick note about that to the UI while merging.
See https://forum.terasology.org/threads/gsoc-2018-multiple-worlds.2168 and the linked blog entries for further GSOC project details :-)