Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for version file for launcher + increment to next major release #4672

Merged
merged 3 commits into from
May 16, 2021

Conversation

Cervator
Copy link
Member

This quick-fixes Terasology/Index#16 and should let the launcher identify newer Omega zips from Jenkins, as the versionInfo.properties is again attached from a slightly updated path then retrieved during the Omega zip making.

Goes with Terasology/Index#17

Additionally I think we're overdue for bumping the engine version to the next major, considering the next release will include the major upgrade to Gestalt v7, that definitely deserves a bump.

If no objections we should also adjust the current milestone accordingly: https://github.com/MovingBlocks/Terasology/milestones/45/edit

And I think #4509 should probably be closed as complete as part of that? I know there are still leftovers floating around, but that core issue seems to deserve its finished status 👍

Omega fix confirmed with https://jenkins.terasology.io/teraorg/job/Nanoware/job/Omega/job/develop/34/

Cervator added 2 commits May 15, 2021 22:43
…alt upgrade)

chore: version bump to mark next release major (due to the major Gestalt upgrade)
@Cervator Cervator added the Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. label May 16, 2021
@Cervator Cervator added this to the v4.4.1 milestone May 16, 2021
@Cervator
Copy link
Member Author

@keturn
Copy link
Member

keturn commented May 16, 2021

Limit PR scope to a single issue, please! Unless the issues are intertwined, but that doesn't look to be the case here.

I'm picking on this one a bit because while it is often quite practical to include some one-line change along with the other work in a PR as some bit of incidental cleanup, this PR description talks more about the things that aren't the targeted issue than the fix itself.

(despite me picking on it, I recognize there is more description of the issue and its fix on both Index#16 and Index#17)

I do agree that this change to the Jenkinsfile in combination with the linked change to Index/Jenkinsfile should be sufficient to repair things.

@Cervator Cervator merged commit 39b28fa into MovingBlocks:develop May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins omega build has no versionInfo.properties artifact
2 participants