Fix for #16 #17
Merged
Fix for #16 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cervator
added
the
Category: Build/CI
|
Hmm, this is a complication of accepting PRs sourced from because we encourage force-pushing to Nanoware to try out new experiments and, like, what are those other commits? were they really intended to be here in the main repo? if so, how did they get lost? accident, or were they proposed in some other PR and rejected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit history went a little funny between these two repos, unique module list editing in different places, but I think it should be okay? FlyingIslands is but isn't in the lineup already ... I dunno. Not the important part in any case and we can always tweak if needed.
Mostly it is the tiny path tweak that fixes #14 and goes with an associated engine PR.