Created a new page type for PNI Privacy Index page #11107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmmavis
changed the title
mmmavis
changed the title
|
|
mmmavis
changed the title
6 tasks
mmmavis
commented
Sep 18, 2023
network-api/networkapi/templates/buyersguide/pages/consumer_creepometer_page_2023.html
Show resolved
Hide resolved
mmmavis
changed the title
mmmavis
commented
Sep 18, 2023
mmmavis
force-pushed
the
11076-pni-privacy-index
branch
from
22c1b60 to
b13e304
Compare
mmmavis
commented
Sep 18, 2023
network-api/networkapi/templates/buyersguide/pages/consumer_creepometer_page.html
Show resolved
Hide resolved
mmmavis
force-pushed
the
11076-pni-privacy-index
branch
from
f444ec3 to
8cfdd26
Compare
There was a problem hiding this comment.
Great job on these, @mmmavis! I just have some minor comments
network-api/networkapi/wagtailpages/tests/buyersguide/test_consumer_creepometer_page.py
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/tests/buyersguide/test_consumer_creepometer_page.py
Outdated
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/tests/buyersguide/test_consumer_creepometer_page.py
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/tests/buyersguide/test_consumer_creepometer_page.py
Outdated
Show resolved
Hide resolved
mtdenton
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Created a new page type for PNI Privacy Index page (#11107) * Create a new page type for PNI annual consumer creep-o-meter * fix migration conflict * PNI Consumer Creep-O-Meter Page Hero (#11146) * got general section structure in * implemented hero section * PNI CC Page - Sub Nav + 3 middle sections (#11156) * implemented the "sub nav", "big picture trends", "best & worst products" and "by the numbers" sections * PNI CC Page - Quiz section (part 1) (#11211) * Quiz Section Part 1 work. Includes the product selection screen and the result screen only. * PNI CC Page - Outro section + Newsletter box at the bottom of Quiz section (#11219) * Modified the existing PNI newsletter box setup so it can be used for difference scenarios & built Outro section & added newsletter box to Quiz section * fix migration conflicts * linting * updated all face existing SVGs * PNI CC Page - remaining work for Quiz Part 2 (#11224) * Added the newsletter signup prompt and thank you messages to quiz flow * PNI CC Page - Animated Eyes (#11241) * moved hero section to its own fragment file * animated creepy eyes * 11213 quiz share buttons (#11239) * Share buttons on Quiz section * PNI CC Page - MVP version of 'Stay in Control' section (#11245) * Added MVP version of 'Stay in Control' section * PNI CC Page - fixes and improvements (#11242) * fixes and improvements * [PNI CC Page] More fixes (#11248) * optimized face-5.svg * hero creepy face position adjectment --------- Co-authored-by: Daniel Miranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the new PNI index page (Annual Consumer Creep-O-Meter page) work.
Code changes in this PR are going to the feature branch
feature-pni-privacy-index-2023Related PRs/issues: #11076
Please refer to the checklist in the ticket #11076 . Basically we are adding a new page type for PNI. Content is hardcoded and doesn't need to be editable on CMS. I added a field
yearjust because this has the possibility of being an annual thing if this year's launch goes well. This field isn't in the specs so we can def remove it if you see any concern with it.