This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Fix for 19: Role closed messages #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a command is interrupted, it will notify its owner of the interruption with a message identifying the command. This will prevent calls waiting until timeout (potentially forever) while waiting for a response. The on_close role callbacks are now properly called on termination. Note: the Message.receive_macro now includes a clause for handling these messages, but it might be improved to take advantage of more specific matching. This commit also includes some cleanup of the Publisher role -- it was carrying around unnecessary state.
Inline with the rest of OTP, `state` should be the final element of the return tuples.
By handing the unexpected error return in the case statement, the error would be silently swallowed. Additional small whitespace cleanup -- couldn't resist.
jtmoulia
added a commit
that referenced
this pull request
Jan 25, 2016
Fix for 19: Role closed messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issue #19, though it also contains some other fixes found along the way.
When a command is interrupted, it will notify its owner of the interruption with a message identifying the command. This will prevent calls waiting until timeout (potentially forever) while waiting for a response.
The on_close role callbacks are now properly called on termination.
Note: the Message.receive_macro now includes a clause for handling these messages, but it might be improved to take advantage of more specific matching.