-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official address encoding base58check Vs bech32 vs base64 #1
Comments
after some attempts on using bech32 as Address and ObjectID encoding: MystenLabs/sui#5643 there are few challenges that is hard to overcome due to
Decision: to keep the address in hex instead of Bech32 |
Another question is whether we want to use 32 or 20 bytes for an hex address? this should be less invasive since there is a flag in Move to do this already. See all changes needed in MystenLabs/sui#6700 |
cc @Jordan-Mysten to add considerations for address 32 bytes frontend also cc @kchalkias |
@kchalkias, @joyqvq can we close this one? do you think we will want to change it in the future? |
MystenLabs/sui#8542 considers 32 bytes hex as final address format for mainnet. |
* Group elements to and from uncompressed form * Add ToFromUncompressedBytes impl for G2Elements * docs + tests * add sum function * clippy * benchmarks * add fast sum function * very fast version works * clean up * keep only 'safe' version * clean up * more test cases * name * add to_bytes method * Clean up * benchmarks + docs * regression test * review comments #1 * test * tests * test * test * use vector of ptrs * remove redundant comment
discuss after public testnet
The text was updated successfully, but these errors were encountered: