Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: Use bech32 for SuiAddress encoding #5643

Closed
wants to merge 1 commit into from
Closed

crypto: Use bech32 for SuiAddress encoding #5643

wants to merge 1 commit into from

Conversation

joyqvq
Copy link
Contributor

@joyqvq joyqvq commented Oct 28, 2022 •
edited
Loading

(Bech32 struct should belong to fastcrypto. use here for fast PoC coding)

  • address length 20 bytes -> 32 bytes
  • address format hex -> bech32 with hrp = su
  • objectID format hex -> bech32 with hrp = so

@joyqvq joyqvq force-pushed the bech32 branch 2 times, most recently from 08b4f52 to 2116006 Compare October 28, 2022 15:13
@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Oct 28, 2022
@MystenLabs MystenLabs deleted a comment from Oussamaslimi1220 Oct 30, 2022
@joyqvq joyqvq force-pushed the bech32 branch 2 times, most recently from 2c22a92 to a493a20 Compare October 31, 2022 13:55
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2022 •
edited
Loading

💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3624750333#artifacts

@joyqvq joyqvq force-pushed the bech32 branch 2 times, most recently from 26f2aa3 to ff16ca6 Compare November 1, 2022 15:53
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@joyqvq joyqvq force-pushed the bech32 branch 6 times, most recently from ac4f5f7 to 4412e1b Compare November 3, 2022 15:21
@vercel
Copy link

vercel bot commented Dec 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
explorer ❌ Failed (Inspect) Dec 5, 2022 at 11:03PM (UTC)

@joyqvq joyqvq closed this Dec 9, 2022
@joyqvq joyqvq mentioned this pull request Dec 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronny-mysten ronny-mysten Awaiting requested review from ronny-mysten ronny-mysten will be requested when the pull request is marked ready for review ronny-mysten is a code owner

@patrickkuo patrickkuo Awaiting requested review from patrickkuo patrickkuo will be requested when the pull request is marked ready for review patrickkuo is a code owner

Assignees
No one assigned
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joyqvq