Use pre-computation to speed-up Secp256r1 verification #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-lj
force-pushed
the
jonas/precompute
branch
from
99a2905 to
a567976
Compare
This was
linked to
issues
May 24, 2023
jonas-lj
force-pushed
the
jonas/precompute
branch
from
7103488 to
0d66c5a
Compare
benr-ml
reviewed
May 24, 2023
benr-ml
reviewed
May 24, 2023
kchalkias
reviewed
May 26, 2023
kchalkias
reviewed
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #588 and #573 (because the construction is similar to the one used by openssl, but with modification required for pure Rust)
This PR made to speed up signature verification in Secp256r1 (gives about ~50% speed-up), but it is implemented for generic groups, so it may also be used for other constructions, eg Ristretto (#589) so it's also relevant for #590. It uses a sliding window method (which is variable time) for verification and fixed window (which is constant time) for signing.
The BGMW algorithm is not used for ecdsa, but is faster for single scalar multiplications at the cost of larger precomputation tables. It has been added under the experimental feature flag.