telemetry-subscribers: remove feature flags #20820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the feature flags from the `telemetry-subscribers` crate. The existing flags were not being proberly handled which could have lead to broken compilation if features were enabled/disabled and given we don't make use of feature flags in the sui repo it makes things easier to maintain with these removed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
|
How is the tokio console feature controlled after this PR? |
Build with the Run with Run tokio-console This PR makes sure that running |
lxfind
approved these changes
Jan 8, 2025
lxfind
pushed a commit
that referenced
this pull request
Jan 9, 2025
Remove the feature flags from the `telemetry-subscribers` crate. The existing flags were not being properly handled which could have lead to broken compilation if features were enabled/disabled and given we don't make use of feature flags in the sui repo it makes things easier to maintain with these removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the feature flags from the
telemetry-subscriberscrate. The existing flags were not being proberly handled which could have lead to broken compilation if features were enabled/disabled and given we don't make use of feature flags in the sui repo it makes things easier to maintain with these removed.Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.