Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry-subscribers: remove feature flags #20820

Merged
merged 1 commit into from
Jan 8, 2025
Merged

telemetry-subscribers: remove feature flags #20820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions crates/telemetry-subscribers/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@ publish = false

[dependencies]
atomic_float.workspace = true
console-subscriber = { workspace = true, optional = true }
console-subscriber.workspace = true
crossterm.workspace = true
once_cell.workspace = true
prometheus.workspace = true
tracing.workspace = true
tracing-appender.workspace = true
tracing-subscriber.workspace = true
opentelemetry = { version = "0.25.0", optional = true }
opentelemetry_sdk = { version = "0.25.0", features = ["rt-tokio"], optional = true }
opentelemetry-otlp = { version = "0.25.0", features = ["grpc-tonic"], optional = true }
tracing-opentelemetry = { version = "0.26.0", optional = true }
opentelemetry-proto = { version = "0.25", optional = true }
opentelemetry = { version = "0.25.0" }
opentelemetry_sdk = { version = "0.25.0", features = ["rt-tokio"] }
opentelemetry-otlp = { version = "0.25.0", features = ["grpc-tonic"] }
tracing-opentelemetry = { version = "0.26.0" }
opentelemetry-proto = { version = "0.25" }
tokio = { workspace = true, features = ["full"] }
futures.workspace = true
clap.workspace = true
Expand All @@ -33,16 +33,5 @@ bytes-varint = { version = "1" }
tonic = { version = "0.12.3" }
prost = "0.13"

[features]
default = ["otlp"]
tokio-console = ["console-subscriber"]
otlp = [
"tracing-opentelemetry",
"opentelemetry",
"opentelemetry-otlp",
"opentelemetry-proto",
"opentelemetry_sdk"
]

[dev-dependencies]
camino.workspace = true
1 change: 0 additions & 1 deletion crates/telemetry-subscribers/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,6 @@ impl TelemetryConfig {
// tokio-console layer
// Please see https://docs.rs/console-subscriber/latest/console_subscriber/struct.Builder.html#configuration
// for environment vars/config options
#[cfg(feature = "tokio-console")]
if config.tokio_console {
layers.push(console_subscriber::spawn().boxed());
}
Expand Down
Loading