-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement auto-serialization #1072
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1072 +/- ##
=======================================
+ Coverage 16% 16% +1%
=======================================
Files 233 234 +1
Lines 7293 7235 -58
=======================================
+ Hits 1139 1140 +1
+ Misses 6154 6095 -59 |
Not looking into the code now, I noticed the amount of files generated by the package. Declarate a library with the json annotation import as well all the parts of all of the models and in each model file include Feel free to follow or not this idea. |
129137b
to
2f37506
Compare
d26354f
to
477a85f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have the chance to test this properly, but looking at the code seems all fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3f9d854
to
672d7da
Compare
417c250
to
bd61b50
Compare
@rubuy-74 can you rebase this? |
ac8ba1a
to
6bdbff1
Compare
6bdbff1
to
d1cc8b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, please fix the linting and address some issues below 🚀
8af5ad2
to
f2b4916
Compare
f2b4916
to
7a78e8a
Compare
c98ec01
to
a53c0e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice job 🚀
Closes #662.
Continues the work started in #837.
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change