Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schedule null api URL #1316

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix schedule null api URL #1316

merged 1 commit into from
Sep 10, 2024

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Sep 10, 2024

When a student does not have their schedule yet, the page does not have the required tag to access the api url.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link
Member

@limwa limwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 16%. Comparing base (8a518bc) to head (593a4cd).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1316   +/-   ##
=======================================
  Coverage       16%     16%           
=======================================
  Files          239     239           
  Lines         7172    7172           
=======================================
  Hits          1078    1078           
  Misses        6094    6094           

Copy link
Contributor

@rubuy-74 rubuy-74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@DGoiana DGoiana merged commit 0947552 into develop Sep 10, 2024
6 checks passed
@DGoiana DGoiana deleted the fix/schedule-null-api-url branch September 10, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants