Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schedule null api URL #1316

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix schedule null api URL #1316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/uni_app/lib/controller/fetchers/schedule_fetcher/schedule_fetcher_new_api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ class ScheduleFetcherNewApi extends ScheduleFetcher {

final scheduleApiUrl = getScheduleApiUrlFromHtml(scheduleResponse);

if (scheduleApiUrl == null) {
return <Lecture>[];
}

final scheduleApiResponse = await NetworkRouter.getWithCookies(
scheduleApiUrl,
{},
Expand Down
6 changes: 1 addition & 5 deletions packages/uni_app/lib/controller/parsers/schedule/new_api/parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,14 @@ import 'package:uni/model/entities/lecture.dart';
/// Extracts the user's lecture API URL.
///
/// This function parses the schedule's HTML page.
String getScheduleApiUrlFromHtml(
String? getScheduleApiUrlFromHtml(
http.Response response,
) {
final document = parse(response.body);

final scheduleElement = document.querySelector('#cal-shadow-container');
final apiUrl = scheduleElement?.attributes['data-evt-source-url'];

if (apiUrl == null) {
throw Exception('Could not find schedule API URL in schedule page');
}

return apiUrl;
}

Expand Down