Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partition number checking failing in ww3_ounf #2

Closed
ajhenrique opened this issue Mar 27, 2019 · 3 comments
Closed

Partition number checking failing in ww3_ounf #2

ajhenrique opened this issue Mar 27, 2019 · 3 comments
Assignees
@ukmo-ccbunney
Labels
bug Something isn't working
Milestone
6.07.X Public Rel...

Comments

@ajhenrique
Copy link
Collaborator

ajhenrique commented Mar 27, 2019 •
edited
Loading

A bug in ww3_ounf is causing the netcdf gridded post-processing wrapper to fail. The line

IF(NBIPART .GT. NOSWLL) THEN

needs to be changed to

IF(NBIPART .GT. NOSWLL+1) THEN

this reflects the fact NOSWLL sets the number of swell partitions in addition to the windsea partition thus a total of NOSWLL+1 partitions.

@aliabdolali @ajhenrique @ukmo-ccbunney
@ajhenrique ajhenrique added the bug Something isn't working label Mar 27, 2019
@ukmo-ccbunney
Copy link
Collaborator

ukmo-ccbunney commented Mar 28, 2019 •
edited by ajhenrique
Loading

This affects the ALLOCATE statement at line 384 in a similar fashion; the TABIPART array needs to be 1 element larger:

ALLOCATE(TABIPART(NOSWLL + 1))

ukmo-ccbunney referenced this issue in ukmo-waves/WW3 Mar 28, 2019
@ukmo-ccbunney
Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accoutin…
14ba7e0 
…g for zeroth wind partition. See Issue #2.
@ukmo-ccbunney ukmo-ccbunney mentioned this issue Mar 28, 2019
Merged
@ukmo-ccbunney
Copy link
Collaborator

Pull request #3 raised.

ajhenrique pushed a commit that referenced this issue Apr 4, 2019
@ukmo-ccbunney @ajhenrique
Hotfix: NBIPART max value check failing in WW3_OUNF program (#3)
7e618b5 
Merging hotfix branch ukmo-waves:HF_ounfpart -> NOAA-EMC/WW3:HF_ounfpart:

* Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accouting for zeroth wind partition. See Issue #2.

* Updated comments

* Moved broken ww3_grid*.nml files into subdirectory within input dir.
Updated info to stress that test needs to be run with -N flag.
@ajhenrique
Copy link
Collaborator Author

The issue has been solved. To be reintegrated to the NOAA-EMC master pending regtests.

@ajhenrique ajhenrique mentioned this issue Apr 19, 2019
Merged
ajhenrique added a commit that referenced this issue Apr 19, 2019
@ajhenrique
HF ounfpart + NCO switch + DB1 coeff (#14)
b582f8c 
Merging Hotfixes branch HF_ounfpart into the WW3 master. 

* Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accouting for zeroth wind partition. See Issue #2.
* Updating link.wcoss_phase2 for grib compile, removing !$ lines in ww3_uprstr that broke compilation of codes with OMPH OMPG switch flags, added new global wave model switch. Added option for writing to fixed netcdf gridded output file when using NCO switch (the issue will be fixed more adequately in v7 following Issue #8).
* DB1 depth-breaking_bugfix: added proper scaling coefficients for radian freq. [radHz]. See issue #7.

Merge will lead to v6.07.1, tag and release will be updated accordingly.
@ajhenrique ajhenrique mentioned this issue Apr 23, 2019
Merged
ajhenrique added a commit that referenced this issue Apr 23, 2019
@ajhenrique
HotFix: ounfpart + NCO switch + DB1 coeff (v6.07.1) (#16)
2b1ea78 
HF ounfpart integrates hotfixes from the NCEP/NOAA-EMC auth repo and the trusted repos UKMO and ERDC. The following hotfixes are implemented with this pull request:

* Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accouting for zeroth wind partition. See Issue #2.
* Updating link.wcoss_phase2 for grib compile, removing !$ lines in ww3_uprstr that broke compilation of codes with OMPH OMPG switch flags, added new global wave model switch.
* Added option for writing to fixed netcdf gridded output file when using NCO switch (the issue will be fixed more adequately in v7 following Issue #8).
* DB1 depth-breaking_bugfix: added proper scaling coefficients for radian freq. [radHz]. See issue #7 .

Hotfixes were tested using the full regression testing matrix at NCEP which resulted in differences only in regtests wher DB1 was employed, as expected.
@ajhenrique ajhenrique mentioned this issue Apr 25, 2019
Closed
CarstenHansen added a commit to CarstenHansen/WW3 that referenced this issue Jul 1, 2019
@CarstenHansen
FB_rtd2: Fix two minor bugs in ww3_grid.ftn: Info about outbound files
c12dd05 
Bug #1: If namelists input files are used, a code block is not reached
that writes info to NDSO about the last boundary file: "File nestI.ww3
Number of points .." (after the last line I == NML_OUTBND_COUNT%N_LINE).

Bug NOAA-EMC#2: A code line "WRITE(NDSS,'(A)') NML_OUTBND_LINE(I-1)" writes
garbage to file ww3_grid.scratch, because the NML_OUTBND_LINE elements
are not strings.

Implication: Affects the user's ability to control the configuration.

Solution bug #1: Let NPO=0 mark that we have got the info for the last
output b.c. file, and the do-loop over outbound lines will exit
immediately after the block that writes the info.

Solution bug NOAA-EMC#2: Ommit the write statement. The file ww3_grid.scratch
isn't used when namelists input files are used. Therefore, also
prepend a condition "IF (.NOT. FLGNML)" to the two statements
"OPEN ( NDSS,FILE=TRIM(FNMPRE)//'ww3_grid.scratch',..." and
"CLOSE ( NDSS,...".

Remaining issue: Update manual section "4.4.3 The grid preprocessor"
@DiegoGutierrez2210 DiegoGutierrez2210 mentioned this issue Sep 26, 2019
Closed
@DiegoGutierrez2210 DiegoGutierrez2210 mentioned this issue Oct 3, 2019
Closed
@DiegoGutierrez2210 DiegoGutierrez2210 mentioned this issue Jan 22, 2020
Closed
@iman-j iman-j mentioned this issue Feb 25, 2020
Closed
@DiegoGutierrez2210 DiegoGutierrez2210 mentioned this issue Jun 28, 2020
Closed
@thesser1 thesser1 mentioned this issue Dec 7, 2020
Closed
JessicaMeixner-NOAA referenced this issue in JessicaMeixner-NOAA/WW3 Dec 2, 2021
@kgerheiser
Merge pull request #2 from JessicaMeixner-NOAA/feature/cmakeregtests
d43a421 
Merge CMake regtests branch
qingli411 pushed a commit to qingli411/WW3 that referenced this issue Apr 30, 2022
@DeniseWorthen
Merge pull request NOAA-EMC#2 from kgerheiser/feature/cmake_meshcapbuild
77ea136 
Add new cap options to CMake
qingli411 pushed a commit to qingli411/WW3 that referenced this issue May 7, 2022
@alperaltuntas
Merge pull request NOAA-EMC#2 from mvertens/feature/icewav_coupling
67b1ff4 
updates to ww3 cap code for ww3/cice coupling
This was referenced Aug 23, 2022
Open
Closed
@JMSnyder1980 JMSnyder1980 mentioned this issue Feb 15, 2023
Closed
@edwardhartnett edwardhartnett mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukmo-ccbunney ukmo-ccbunney

Labels
bug Something isn't working
Projects
None yet
Milestone
6.07.X Public Release version hotfixes
Development

No branches or pull requests
2 participants
@ajhenrique @ukmo-ccbunney