HotFix: ounfpart + NCO switch + DB1 coeff #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging hotfix branch ukmo-waves:HF_ounfpart -> NOAA-EMC/WW3:HF_ounfpart: * Bugfix in ww3_ounf.ftn: NBIPART check against NOSWLL was not accouting for zeroth wind partition. See Issue #2. * Updated comments * Moved broken ww3_grid*.nml files into subdirectory within input dir. Updated info to stress that test needs to be run with -N flag.
Accepting HF that contains several changes needed for version 6.07 to work for NCEP applications: * Branch HF_NCOswitch_ndso: Changing README.md TM->R, adding grib2 link options to link, creating switch for GLWU, changing w3_make to allow grib compilation * Branch HF_NCOswitch_ndso: Updating link.wcoss_phase2 for grib compile, fixing OMPH OMPG switch flags that broke uprstr compilation, added new global wave model switch * Branch HF_NCOswitch_ndso: reverting change in ounf that belongs to UKMO branch
Adding bugfix to depth breaking DB1. * breaking_bugfix: add proper scaling for radian freq. [radHz] * breaking_bugfix: Add some comments ... * update comments ... * update comments ... * changed version number in header from 7.00 to 6.07 * minor formatting fix on header
ajhenrique
changed the title
aliabdolali
pushed a commit
that referenced
this pull request
Nov 5, 2020
* Fb oasis t+0 (#13) In the original code a coupling lag had to be used, coupling took place at the last time step but not at the first, and the coupling fields had to be written in an oasis restart file. With this ticket, the program can run in a different way by not using a coupling lag, coupling taking place at the first time step but not the last, and the coupling fields are written in the wave restart file - no extra oasis restart file needed. * Fb uprstr inp (#15) Enhancement to improve the way in which input data is read in and logged by the ww3_uprstr program: * read in variables specific to the update process selected * output the values provided in the ww3_uprstr.out log file * update the .inp template file and regtests to improve clarity and work with the changes * add capability to read inputs from a namelist (ww3_uprstr.nml) file * Bf unconforming where in coupling routines (#17) * Fix non-conforming WHERE statements in coupled routines * Stop comparing history lines in OASIS rmp files * Changes for efficient SMC grid coupling (#16) * Changes for efficient SMC grid coupling * Ensure consistency between SMC coupled test nml and inp files Co-authored-by: Juan Manuel Castillo Sanchez <[email protected]> Co-authored-by: Andy Saulter <[email protected]>
MatthewMasarik-NOAA
pushed a commit
that referenced
this pull request
Oct 18, 2023
* small update of modelBuoy_collocation.py to avoid errors when reading the buoy stations. Inclusion of documentation files in the new folder docs. * New REAMDME with text, figures, links to data, references, and proper format.
MatthewMasarik-NOAA
pushed a commit
to MatthewMasarik-NOAA/WW3
that referenced
this pull request
Dec 19, 2023
…-dev/unified Langmuir updates: PR to address comments made on NOAA-EMC/WW3 NOAA-EMC#1034
mvertens
added a commit
to mvertens/WW3
that referenced
this pull request
Sep 23, 2024
bug fix for bug that was reintroduced in attenuation merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HF ounfpart integrates hotfixes from the NCEP/NOAA-EMC auth repo and the trusted repos UKMO and ERDC. The following hotfixes are implemented with this pull request:
Hotfixes were tested using the full regression testing matrix at NCEP which resulted in differences only in regtests wher DB1 was employed, as expected.