Hotfix/hf master (#45)

[ajhenrique]

Hotfix featuring:

• bugfix for netcdf file id allocation bugfix for netcdf file id allocation #34
• remove extra line due to copy/paste error Extra line in ww3_shel.ftn #13
• add WCOR to switch list WCOR switch missing #40
• add check on array index UG_GETOPENBOUNDARY index #41
• undo modification on ndates
• add feature for fixed filename with ndates=0 for ww3_ounf OUNF allowing fixed output file name #23
• add slurm option for batch queue management in run_test for regtests Add option for slurm batch queueing using regtests matrix #43

In running the full regtests matrix prior to this pull request, there were the expected differences in mww3_test_03 case dN with load balancing options, and in mod_defs for one variation of 3 tests (mww3_test_07, ww3_tp2.7, and ww3_ts4). In my view these results are robust, they identify something that needs to be fine-combed in the generation of mod_defs for these latter tests, but that indicate that all branches are ready for merge.

regtests matrix output run on Theia

---

********************* non-identical cases ****************************

---

mww3_test_03/./work_PR3_UQ_MPI_d2 (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c (8 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2 (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2 (3 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c (3 files differ)
mww3_test_03/./work_PR1_MPI_d2 (7 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2 (4 files differ)
mww3_test_07/./work_PR3_UQ (3 files differ)
ww3_tp2.7/./work_ST0 (1 files differ)
ww3_ts4/./work_ug_MPI (1 files differ)

---

******************** summary of comparison ***************************
********** only results of non-identical cases are listed ************
****** if less than 10 files differ for a case, they are listed ******

---

• test case: mww3_test_03; test run: ./work_PR3_UQ_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
124 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
8 files differ
out_pnt.low2 (binary) out_grd.low2 (binary) out_grd.low3 (binary) out_grd.low1 (binary) out_pnt.hgh2 (binary) out_grd.hgh2 (binary) out_grd.hgh3 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR3_UQ_MPI_d2_c

---

found 135 files in base directory
found 135 files in compare directory
124 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
8 files differ
out_pnt.low2 (binary) out_grd.low2 (binary) out_grd.low3 (binary) out_grd.low1 (binary) out_pnt.hgh2 (binary) out_grd.hgh3 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR2_UQ_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
126 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
6 files differ
out_pnt.low2 (binary) out_grd.low2 (binary) out_grd.low1 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary) restart001.low1 (binary)

• test case: mww3_test_03; test run: ./work_PR3_UNO_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
129 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
3 files differ
out_grd.low2 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR3_UNO_MPI_d2_c

---

found 135 files in base directory
found 135 files in compare directory
129 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
3 files differ
out_grd.low2 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR1_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
125 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
7 files differ
out_grd.low3 (binary) out_grd.low2 (binary) out_grd.low1 (binary) out_grd.hgh3 (binary) out_pnt.hgh2 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_03; test run: ./work_PR2_UNO_MPI_d2

---

found 135 files in base directory
found 135 files in compare directory
128 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
4 files differ
out_grd.low2 (binary) out_grd.low1 (binary) out_grd.hgh2 (binary) out_grd.hgh1 (binary)

• test case: mww3_test_07; test run: ./work_PR3_UQ

---

found 25 files in base directory
found 25 files in compare directory
19 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
3 files differ
mod_def.rect1 (binary) mod_def.points (binary) mod_def.zcmpl (binary)

• test case: ww3_tp2.7; test run: ./work_ST0

---

found 78 files in base directory
found 78 files in compare directory
74 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
1 files differ
mod_def.ww3 (binary)

• test case: ww3_ts4; test run: ./work_ug_MPI

---

found 13 files in base directory
found 13 files in compare directory
9 files are identical
3 files skipped
0 files in base directory only
0 files in comp directory only
1 files differ
mod_def.ww3 (binary)

[JessicaMeixner-NOAA]

Commit looks good. Only comment is this also needs a PR for being merged into develop as well.

[ajhenrique]

Commit looks good. Only comment is this also needs a PR for being merged into develop as well.

@JessicaMeixner-NOAA changes proposed here are also to be merged into develop. We will follow the procedure for reintegrating directly from the Ifremer develop branch in that case. @mickaelaccensi will submit a pull request from the Ifremer develop branch providing output from his regtests matrix run for approval by reviewers.

[mickaelaccensi]

the only differences are in mww3_test05 due to a different number of time steps. Otherwise all the files are the same bit to bit. see the output of matrix.comp between full matrix from HF_ifremer_pull_20190521 and master branch

NOAA_HF_ifremer_pull_20190521_matrixDiff.txt