Extra line in ww3_shel.ftn #13
Labels
bug
Something isn't working
Comments
|
To be able to help, we need to know what switch you used to compile the code and what your ww3_shel.inp file is. |
|
Hi, thanks for the help. Here are the files |
|
@AndresSepulveda it looks like this was an issue introduced in revision 4994ca. @mickaelaccensi could you please check? It looks like line 1300 was introduced with the intention of replacing line 1303, but line 1303 was never deleted? |
|
the line 1300 must be deleted : |
|
ok, thanks. |
|
@mickaelaccensi do you think this bugfix would warrant a HF to the master? IOW, would this cause the code to fail in a way that would significantly affect usage of ww3_shel? In any case, could either you or @AndresSepulveda create a BF branch from your fork, fix the issue and submit a pull request? |
|
ok I'll do it next week |
Merged
Merged
|
@AndresSepulveda can you close this issue since it has been integrated into master and develop branches. thanks |
Closed
aliabdolali
pushed a commit
that referenced
this issue
Nov 5, 2020
* Fb oasis t+0 (#13) In the original code a coupling lag had to be used, coupling took place at the last time step but not at the first, and the coupling fields had to be written in an oasis restart file. With this ticket, the program can run in a different way by not using a coupling lag, coupling taking place at the first time step but not the last, and the coupling fields are written in the wave restart file - no extra oasis restart file needed. * Fb uprstr inp (#15) Enhancement to improve the way in which input data is read in and logged by the ww3_uprstr program: * read in variables specific to the update process selected * output the values provided in the ww3_uprstr.out log file * update the .inp template file and regtests to improve clarity and work with the changes * add capability to read inputs from a namelist (ww3_uprstr.nml) file * Bf unconforming where in coupling routines (#17) * Fix non-conforming WHERE statements in coupled routines * Stop comparing history lines in OASIS rmp files * Changes for efficient SMC grid coupling (#16) * Changes for efficient SMC grid coupling * Ensure consistency between SMC coupled test nml and inp files Co-authored-by: Juan Manuel Castillo Sanchez <[email protected]> Co-authored-by: Andy Saulter <[email protected]>
JessicaMeixner-NOAA
pushed a commit
to JessicaMeixner-NOAA/WW3
that referenced
this issue
Feb 16, 2021
In the original code a coupling lag had to be used, coupling took place at the last time step but not at the first, and the coupling fields had to be written in an oasis restart file. With this ticket, the program can run in a different way by not using a coupling lag, coupling taking place at the first time step but not the last, and the coupling fields are written in the wave restart file - no extra oasis restart file needed.
aliabdolali
added a commit
that referenced
this issue
May 18, 2021
This PR adds new fields that can be sent (mean wave number, mean wave period, total ocean wind stress) and received (air density, wind stress) to/from other models via OASIS coupling, which will also be available in the model output. The fields that can be received via coupling can also be read from an external file, and using a homogeneous ice fraction is now activated when using '.inp' input files, as it was already possible to do it using '.nml' input files. In order to add this functionality it was necessary to modify the format of the ww3_shel.inp and ww3_multi.inp files, so that new flags controlling if these fields are used can be read. Furthermore, the format of the ww3_outf.inp file must be modified to accommodate the new output fields available. If no air density is read from file or via coupling, the default constant value is used. The infrastructure to read and use the wind stress is already in place, but the actual use of wind stress to drive the model is not implemented yet and it will be the aim of issue #337 * Fb oasis t+0 (#13) In the original code a coupling lag had to be used, coupling took place at the last time step but not at the first, and the coupling fields had to be written in an oasis restart file. With this ticket, the program can run in a different way by not using a coupling lag, coupling taking place at the first time step but not the last, and the coupling fields are written in the wave restart file - no extra oasis restart file needed. * Fb uprstr inp (#15) Enhancement to improve the way in which input data is read in and logged by the ww3_uprstr program: * read in variables specific to the update process selected * output the values provided in the ww3_uprstr.out log file * update the .inp template file and regtests to improve clarity and work with the changes * add capability to read inputs from a namelist (ww3_uprstr.nml) file * First set of changes, still testing * Some fixes * Further changes mainly fixing vector boundaries * Main changes * Most changes already present, only need to write in output and restart * Further changes - activate coupling * Bug fixes to make the code compile * Further changes to run regtests * Minor fixes for output, manual, and switches * Small fix to comments in model input * Remove some lines that had to be removed but were overlooked * Substitute ATTX and ATXX switches by WNTX and WNXX; add comments regarding last modification date * Change in file missed in latest commit * Minor changes fixing version change * Small fixes after reviewer's comments and to fix regtest * Changes to pass regtests * Addition of a new regtest and small fixes to ww3_prnc * Time-interpolate air density when read from file * Ensure that units are consistent * Restore long name in metadata for new fieds, and update code version for input files needed in regtest * Update last modification date; corrections for new output field: WNMEAN has now index (2,19) instead of (2,18) * Fixes from Jessica Meixner; update date of last change in restart file * Small fix to the format of the example input file ww3_multi.inp * Some fixes after merging with latest version of develop * Correct one version number * Fix the header of the table printed in log.ww3, should not cause changes in the output * Minor fix in the ww3_shel.inp file of one of the regtests * Update ww3_shel.inp * Some fixes and improvements that were proposed during the review process * Added comment to the new regtests implemented in ww3_tp2.15 Co-authored-by: Andy Saulter <[email protected]> Co-authored-by: ukmo-chris.bunney <[email protected]> Co-authored-by: Ali.Abdolali <[email protected]> Co-authored-by: aliabdolali <[email protected]> Co-authored-by: Chris Bunney <[email protected]>
MatthewMasarik-NOAA
pushed a commit
that referenced
this issue
Oct 18, 2023
…ww3 files as consecutive cycles (#13)
phall-brown
pushed a commit
to Fox-Kemper-Group/WW3
that referenced
this issue
Mar 27, 2024
add tail contribution to the last band of partitioned stokes drift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had an error runinng ww3_shel, it complained about a problem reading ww3_shel.inp
Diving in the code, seems this can be fixed by commenting an extra READ in line 1303
From
READ (NDSI,,END=2001,ERR=2002) IPRT, PRTFRM
!/DEBUGINIT write(740+IAPROC,), 'Before reading IPRT'
!/DEBUGINIT write(740+IAPROC,), 'Before read 2002, case 10'
READ (NDSI,) IPRT, PRTFRM
!/DEBUGINIT write(740+IAPROC,*), ' After read 2002, case 10'
to
READ (NDSI,,END=2001,ERR=2002) IPRT, PRTFRM
!/DEBUGINIT write(740+IAPROC,), 'Before reading IPRT'
!/DEBUGINIT write(740+IAPROC,), 'Before read 2002, case 10'
!!! READ (NDSI,) IPRT, PRTFRM
!/DEBUGINIT write(740+IAPROC,*), ' After read 2002, case 10'
The text was updated successfully, but these errors were encountered: