Skip to content

Commit

Permalink
Add TODOs to improve precision output later.
Browse files Browse the repository at this point in the history
  • Loading branch information
robertbartel authored and hellkite500 committed Dec 21, 2021
1 parent 1e9c956 commit 1b79889
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/realizations/catchment/Bmi_C_Formulation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ std::string Bmi_C_Formulation::get_output_line_for_timestep(int timestep, std::s
throw std::invalid_argument("Only current time step valid when getting output for BMI C formulation");
}

// TODO: see Github issue 355: this design (and formulation output handling in general) needs to be reworked
// Clear anything currently in there
output_text_stream->str(std::string());

Expand Down
1 change: 1 addition & 0 deletions src/realizations/catchment/Bmi_Fortran_Formulation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ string Bmi_Fortran_Formulation::get_output_line_for_timestep(int timestep, std::

// TODO: for now, just get current value, and ignore the timestep param

// TODO: see Github issue 355: this design (and formulation output handling in general) needs to be reworked
// Clear anything currently in there
output_text_stream->str(std::string());

Expand Down
1 change: 1 addition & 0 deletions src/realizations/catchment/Bmi_Multi_Formulation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ string Bmi_Multi_Formulation::get_output_line_for_timestep(int timestep, std::st
// Start by first checking whether we are NOT just using the last module's values
if (!is_out_vars_from_last_mod) {

// TODO: see Github issue 355: this design (and formulation output handling in general) needs to be reworked
// Clear anything currently in the multi formulation's stream buffer
output_text_stream->str(std::string());

Expand Down
2 changes: 2 additions & 0 deletions src/realizations/catchment/Bmi_Py_Formulation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ string Bmi_Py_Formulation::get_output_line_for_timestep(int timestep, std::strin
if (timestep != (next_time_step_index - 1)) {
throw std::invalid_argument("Only current time step valid when getting output for BMI Python formulation");
}

// TODO: see Github issue 355: this design (and formulation output handling in general) needs to be reworked
// Clear anything currently in there
output_text_stream->str(std::string());

Expand Down

0 comments on commit 1b79889

Please sign in to comment.