Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngen segfaults and crashes when using csv file without enough columns and not using csvPerFeature provider #372

Closed
hellkite500 opened this issue Feb 2, 2022 · 0 comments · Fixed by #373
Closed

ngen segfaults and crashes when using csv file without enough columns and not using csvPerFeature provider #372

hellkite500 opened this issue Feb 2, 2022 · 0 comments · Fixed by #373
Assignees
@hellkite500

Comments

@hellkite500
Copy link
Member

If passed a realization config with forcing data defined without a provider key (defualt provider), then ngen can crash attempting to read the forcing data if the csv file used doesn't have the correct number of columns.

Current behavior

Segfaults and crashes with no useful information.

Expected behavior

Inform user of mal-formed forcing data and crash with a reportable error.

Steps to replicate behavior (include URLs)

  1. Construct a custom csv file with LESS THAN 10 columns
  2. Point a realization to this csv file as it's forcing input
  3. DO NOT set forcingProvider: "csvPerFeature" in the forcing config
  4. run ngen with this configuration.
@hellkite500 hellkite500 self-assigned this Feb 2, 2022
hellkite500 added a commit to hellkite500/ngen that referenced this issue Feb 2, 2022
@hellkite500
validate number of aorc columns before reading. fixes NOAA-OWP#372
f7854c1
hellkite500 added a commit to hellkite500/ngen that referenced this issue Feb 2, 2022
@hellkite500
unit test for NOAA-OWP#372
c09b3e4
@hellkite500 hellkite500 linked a pull request Feb 3, 2022 that will close this issue
validate number of aorc columns before reading. fixes #372 #373
Merged
12 tasks
mattw-nws pushed a commit that referenced this issue Feb 10, 2022
@hellkite500 @mattw-nws
validate number of aorc columns before reading. fixes #372
6cabfa2
mattw-nws pushed a commit that referenced this issue Feb 10, 2022
@hellkite500 @mattw-nws
unit test for #372
0d04d52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellkite500 hellkite500

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validate number of aorc columns before reading. fixes #372 hellkite500/ngen
1 participant
@hellkite500