Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses_forcing_file and forcing_file options #570

Closed
mattw-nws opened this issue Jul 13, 2023 · 0 comments · Fixed by #826
Closed

Remove uses_forcing_file and forcing_file options #570

mattw-nws opened this issue Jul 13, 2023 · 0 comments · Fixed by #826
Assignees

Comments

@mattw-nws
Copy link
Contributor

mattw-nws commented Jul 13, 2023

These features were added to support explicitly providing a forcing file path to a BMI model, but no mechanism was ever found/created to accomplish that, and currently the forcing_file value gets stored in the BMI_Adapter<T> and never used. Further, formulations with no forcing input is going to be provided by #569. These should be removed for clarity and maintainability. Documentation should also be updated to remove references. Notably, existing formulations that have this key in their JSON (at least as false) will not break, the key will just be ignored. However, example formulations in the repo should probably have these keys removed from the JSON. There are some tests on this feature (and static friend functions to support them) that will also need to be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants