Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet option fix #376

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Quiet option fix #376

merged 2 commits into from
Feb 3, 2022

Conversation

hellkite500
Copy link
Contributor

@hellkite500 hellkite500 commented Feb 2, 2022

Fixes #375 by including compile definitions for ET_QUIET and NGEN_QUIET, as well as ensuring these are set before the various subdirectory builds are added.

Additions

  • Compile definitions in CMakeLists.txt for ET_QUIET and NGEN_QUIET

Changes

  • Add compiler definitions before calls to add_subdirectory in CMakeLists.txt

Testing

  1. Build tested for QUIET operations using cmake 3.17.5

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • MacOs

@hellkite500 hellkite500 self-assigned this Feb 2, 2022
@hellkite500 hellkite500 added the build Issues related to CMake and building ngen label Feb 2, 2022
@mattw-nws mattw-nws changed the title Quite option fix Quiet option fix Feb 2, 2022
@mattw-nws
Copy link
Contributor

Quite remarkable, I must say.

@mattw-nws mattw-nws merged commit 1213d6e into NOAA-OWP:master Feb 3, 2022
@hellkite500 hellkite500 deleted the quite-option-fix branch March 15, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to CMake and building ngen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiet build options not working
2 participants