Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed image for test model run #378

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Fixed image for test model run #378

merged 2 commits into from
Feb 3, 2022

Conversation

ZacharyWills
Copy link
Contributor

@ZacharyWills ZacharyWills commented Feb 3, 2022

The overall NGEN run for testing was broken, this new dockerfile fixes that.

Additions

Removals

Changes

  • Full model run dockerfile ahs been updated to fix the run.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • [~] Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

  1. Rerun model test with changed dockerfile

Target Environment support

  • Linux

Z and others added 2 commits February 3, 2022 08:50
Removing redundant `git pull` that I use for local testing (see comment in file)
@mattw-nws mattw-nws merged commit aaa9404 into master Feb 3, 2022
@mattw-nws mattw-nws deleted the testing-fix branch February 3, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants